Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635301
| Path | csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Ahern <dsahern@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: net/ipv6: GPF in rt6_device_match |
| Date | Thu, 04 May 2017 00:10:02 +0200 |
| Message-ID | <tDaD7-2VX-5@gated-at.bofh.it> (permalink) |
| References | <tD5tL-7R3-1@gated-at.bofh.it> <tD5WO-8gC-3@gated-at.bofh.it> <tD7ce-Ai-11@gated-at.bofh.it> <tDaD8-2VX-7@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=t+fKcYTLK+9IISTM/8bEDQdnGK4CrkcRn1k+QcXiQNs=; b=WGnHw4vB8jUWjKG2XoqHSUqQpn+MWt2QCYQ7c9X/joO4V5ygNENhzECKCMfm64OdF3 J+ZpoTClN3LiEFJOQV8abs41XQFfcILuscv0ZFunb1FGfW7abkRtPqg2mUMsjliXTSWI /WJGPkkgwK8mjCrY6X7Qp4JAsLFy9YVegMlVcO+UUixmZRjQS3iBj7vdBHhvLOEgbPjH jLWEEILrf9JPn/x4+IklLeP9KzT0gLbss8Sp0ltmNqAmV5zPBvqFrQBz3ChTBxY4woKP z5/6yfDrJvt4/ladAUR+FcgpHYJeyrEV4KSQ7qxm95pU7HODhmU554u1xSEDvfzq0vMu BB0w== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=t+fKcYTLK+9IISTM/8bEDQdnGK4CrkcRn1k+QcXiQNs=; b=sEaPTSfctXQ8hnva/pzpoixf1ZxHJzXU9Zb6pMyz0yFlejYeWr7BxaW4cELcOrDzU5 UMPIjGa4v4gopm1gvVznyT9wlhVF5TNNP4QGvJuzPQguXfKF8GJ+cmaJC1sx5mphAJaM 9S5kWS7KFKtPENonNyI5dU9LtOql1GDLU0bfNAgN8MBriXDvniSfkHkVeSS7evTHcTQX 39EtyA0zKm8JnnKmPNoalUhUi2lEsCy/RiAaYPhOfepfJFk8KOirnaTy5T3TkoXEQNUV 4nqrRufuVvadc6h09LZU/paRqrn7uYP8zveL9555Hjkmy7Q/3NVqusDtc1RcnkUZeied 3ZEg== |
| X-Gm-Message-State | AN3rC/4nHI7lSJtv5ggpJoo/y+MLTrPiGcuKZutzIrIvOYZfY1aBvAg2 FolC1tsXPAnYuQ== |
| X-Received | by 10.98.71.202 with SMTP id p71mr7097641pfi.39.1493849357324; Wed, 03 May 2017 15:09:17 -0700 (PDT) |
| User-Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Andrey Konovalov <andreyknvl@google.com>, "David S. Miller" <davem@davemloft.net>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, James Morris <jmorris@namei.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, Patrick McHardy <kaber@trash.net>, netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Dmitry Vyukov <dvyukov@google.com>, Kostya Serebryany <kcc@google.com>, Eric Dumazet <edumazet@google.com>, syzkaller <syzkaller@googlegroups.com> |
| X-Original-Date | Wed, 3 May 2017 16:09:14 -0600 |
| X-Original-Message-ID | <dece4ab2-86b0-1649-5e34-1a9fa1240792@gmail.com> |
| X-Original-References | <CAAeHK+yfX9ZtpFMTFXKAtjYE17MDBXMQJS_mH0b3=xTuv3jk9g@mail.gmail.com> <CAM_iQpUtVZiKTxnUBYEPLQzJSK+G_=Be-uzwuqph6g2VPsZijw@mail.gmail.com> <4ef76406-8e05-ccdf-fefb-dc47d56c71c9@gmail.com> <CAM_iQpVwBp=11c_SQgNxdONefHfZQiyzRwb2pOGgJVECytOzgg@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1635301 |
Show key headers only | View raw
On 5/3/17 4:02 PM, Cong Wang wrote:
> On Wed, May 3, 2017 at 11:22 AM, David Ahern <dsahern@gmail.com> wrote:
>> On 5/3/17 11:02 AM, Cong Wang wrote:
>>> A quick glance shows we need to simply check local->rt6i_idev
>>> since we do the same check for sprt right above.
>>
>> As I recall, rt6i_idev is set for all routes except null_entry and it is
>> not set on null_entry only because of initialization order.
>
> Are you sure?
>
> if (event == NETDEV_REGISTER && (dev->flags & IFF_LOOPBACK)) {
> net->ipv6.ip6_null_entry->dst.dev = dev;
> net->ipv6.ip6_null_entry->rt6i_idev = in6_dev_get(dev);
> #ifdef CONFIG_IPV6_MULTIPLE_TABLES
> net->ipv6.ip6_prohibit_entry->dst.dev = dev;
> net->ipv6.ip6_prohibit_entry->rt6i_idev = in6_dev_get(dev);
> net->ipv6.ip6_blk_hole_entry->dst.dev = dev;
> net->ipv6.ip6_blk_hole_entry->rt6i_idev = in6_dev_get(dev);
> #endif
> }
>
> Loopback is the first one to register, so null entry is set to
> loopback dev initially. Similar for init_net.
>
Why don't you add a printk and see ;-)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: net/ipv6: GPF in rt6_device_match Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-03 19:10 +0200
Re: net/ipv6: GPF in rt6_device_match David Ahern <dsahern@gmail.com> - 2017-05-03 20:30 +0200
Re: net/ipv6: GPF in rt6_device_match Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-04 00:10 +0200
Re: net/ipv6: GPF in rt6_device_match David Ahern <dsahern@gmail.com> - 2017-05-04 00:10 +0200
Re: net/ipv6: GPF in rt6_device_match Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-04 01:40 +0200
Re: net/ipv6: GPF in rt6_device_match David Ahern <dsahern@gmail.com> - 2017-05-04 04:50 +0200
Re: net/ipv6: GPF in rt6_device_match Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-04 06:00 +0200
Re: net/ipv6: GPF in rt6_device_match David Ahern <dsahern@gmail.com> - 2017-05-04 06:20 +0200
csiph-web