Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636513

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

Show all headers | View raw

On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote:
> El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit:
> 
> > In several instances the driver passes an 'enum pipe' value to a
> > function expecting an 'enum transcoder' and viceversa. Since PIPE_x and
> > TRANSCODER_x have the same values this doesn't cause functional
> > problems. Still it is incorrect and causes clang to generate warnings
> > like this:
> > 
> > drivers/gpu/drm/i915/intel_display.c:1844:34: warning: implicit
> >   conversion from enumeration type 'enum transcoder' to different
> >   enumeration type 'enum pipe' [-Wenum-conversion]
> >     assert_fdi_rx_enabled(dev_priv, TRANSCODER_A);
> > 
> > Change the code to pass values of the type expected by the callee.
> > 
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 4 ++--
> >  drivers/gpu/drm/i915/intel_dp.c      | 6 ++++--
> >  drivers/gpu/drm/i915/intel_hdmi.c    | 6 ++++--
> >  drivers/gpu/drm/i915/intel_sdvo.c    | 6 ++++--
> >  4 files changed, 14 insertions(+), 8 deletions(-)
> 
> Ping, any comments on this patch?

I'm not convinced the patch is making things any better really. To
fix this really properly, I think we'd need to introduce a new enum 
pch_transcoder and thus avoid the confusion of which type of
transcoder we're talking about. Currently most places expect an 
enum pipe when dealing with PCH transcoders, and enum transcoder
when dealing with CPU transcoders. But there are some exceptions
of course.

-- 
Ville Syrjälä
Intel OTC

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Matthias Kaehlcke <mka@chromium.org> - 2017-05-05 19:30 +0200
  Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-05-05 19:50 +0200
    Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Grant Grundler <grundler@chromium.org> - 2017-05-05 21:20 +0200
      Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-05-05 22:20 +0200
        Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Grant Grundler <grundler@chromium.org> - 2017-05-05 22:30 +0200
          Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Matthias Kaehlcke <mka@chromium.org> - 2017-05-05 23:40 +0200
    Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum  mismatches Daniel Vetter <daniel@ffwll.ch> - 2017-05-08 09:30 +0200
      Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-08 10:20 +0200

csiph-web