Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1

From	James Bottomley <James.Bottomley@HansenPartnership.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1
Date	2017-05-05 18:50 +0200
Message-ID	<tDOAx-4hv-11@gated-at.bofh.it> (permalink)
References	<tDz8t-2lS-1@gated-at.bofh.it> <tDBai-3LK-7@gated-at.bofh.it> <tDNXP-402-7@gated-at.bofh.it> <tDOqR-4ap-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-05-05 at 09:33 -0700, Linus Torvalds wrote:
> On Fri, May 5, 2017 at 9:00 AM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > 
> > I'm not going to defend the earlier coding, but you've lost the 
> > real device_add() calls in the merge, meaning the tpm devices don't
> > actually get made visible at all.  I suspect assuming device_add() 
> > is done by cdev_device_add() because of the name is going to be our 
> > next anti-pattern, so you're at least ahead of the game ...
> 
> Don't be silly. That's *exactly* what cdev_device_add() does.

Oh, you're right, sorry, I was going by the patches that were cc'd to
the TPM list, which only had the two line addition for
cdev_device_add() ... apparently no-one sent any updates.  Yes, the new
function looks much better and the resolution works.  Sorry for the
noise.

James

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL] Char/Misc driver patches for 4.12-rc1 Greg KH <gregkh@linuxfoundation.org> - 2017-05-05 02:20 +0200
  Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-05 04:30 +0200
    Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-05-05 18:10 +0200
      Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 Greg KH <gregkh@linuxfoundation.org> - 2017-05-05 18:40 +0200
        Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-05-05 21:50 +0200
        Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-05 22:10 +0200
          Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-06 07:10 +0200
            Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-06 20:10 +0200
              Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-05-06 20:20 +0200
      Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-05 18:40 +0200
        Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-05-05 18:50 +0200

csiph-web