Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636435

Re: [PATCH v8 5/7] coresight: add support for CPU debug module

Show all headers | View raw

On 05/05/17 15:48, Mathieu Poirier wrote:
> On Fri, May 05, 2017 at 02:55:17PM +0100, Sudeep Holla wrote:

[...]

>>
>> Just curious as why this is not registered under coresight bus using
>> coresight_register ? It would be good to group all the coresight devices
>> under that bus if possible.
> 
> The only thing this driver has in common with the coresight framework is the
> name, everything else is completely different.  Coupling them together (because
> of the name) would introduce a lot of hacks and make the code unintelligible. 
> 

I guessed so from the quick glance at it as it needs descriptors with
notion of source, sink and links to register. However I felt odd to not
group under the same "coresight" bus. As someone with least knowledge
on coresight, I would check under "sys/bus/coresight" to check available
devices on the system.

Anyways that's just my thoughts though I agree with you. It may need
more refactoring to support that and it will look hackish if we try to
do that with the code as it stands.

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 0/7] coresight: enable debug module Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:10 +0200
  [PATCH v8 4/7] coresight: refactor with function of_coresight_get_cpu Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200
  [PATCH v8 3/7] coresight: of_get_coresight_platform_data: Add missing of_node_put Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200
  [PATCH v8 6/7] arm64: dts: hi6220: register debug module Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200
  [PATCH v8 5/7] coresight: add support for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200
    Re: [PATCH v8 5/7] coresight: add support for CPU debug module Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-04 00:30 +0200
    Re: [PATCH v8 5/7] coresight: add support for CPU debug module Sudeep Holla <sudeep.holla@arm.com> - 2017-05-05 16:00 +0200
      Re: [PATCH v8 5/7] coresight: add support for CPU debug module Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-05 16:50 +0200
        Re: [PATCH v8 5/7] coresight: add support for CPU debug module Sudeep Holla <sudeep.holla@arm.com> - 2017-05-05 17:10 +0200
          Re: [PATCH v8 5/7] coresight: add support for CPU debug module Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-05 17:40 +0200
  [PATCH v8 1/7] coresight: bindings for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200
  [PATCH v8 2/7] doc: Add documentation for Coresight CPU debug Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200
    Re: [PATCH v8 2/7] doc: Add documentation for Coresight CPU debug Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-04 00:40 +0200
      Re: [PATCH v8 2/7] doc: Add documentation for Coresight CPU debug Leo Yan <leo.yan@linaro.org> - 2017-05-09 05:00 +0200
  [PATCH v8 7/7] arm64: dts: qcom: msm8916: Add debug unit Leo Yan <leo.yan@linaro.org> - 2017-05-02 12:20 +0200

csiph-web