Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636278

[PATCH/RFC] signal: Export signal_wake_up_state() to modules

Show all headers | View raw

When using signal_wake_up() from a loadable kernel module:

    ERROR: "signal_wake_up_state" [drivers/spi/spi-sh-msiof.ko] undefined!

Export signal_wake_up_state() to modules to fix this.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
I'm using signal_wake_up() to abort a task blocked on
wait_for_completion_interruptible(), cfr. sh_msiof_slave_abort() in
"spi: sh-msiof: Add slave mode support"
(http://www.spinics.net/lists/devicetree/msg175575.html).

Is exporting signal_wake_up_state() an acceptable solution?
Alternatively, I can extract the code to abort an completion into a
generic abort_completion() function, and export that.

Or is there a better way to abort a completion?

Thanks!
---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/signal.c b/kernel/signal.c
index 7e59ebc2c25e669e..f130598acd34f08b 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -660,6 +660,7 @@ void signal_wake_up_state(struct task_struct *t, unsigned int state)
 	if (!wake_up_state(t, state | TASK_INTERRUPTIBLE))
 		kick_process(t);
 }
+EXPORT_SYMBOL_GPL(signal_wake_up_state);
 
 /*
  * Remove signals in mask from the pending set and queue.
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH/RFC] signal: Export signal_wake_up_state() to modules Geert Uytterhoeven <geert+renesas@glider.be> - 2017-05-05 11:50 +0200
  Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Christoph Hellwig <hch@infradead.org> - 2017-05-05 12:10 +0200
    Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-05 12:20 +0200
      Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-05 13:10 +0200
        Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Christoph Hellwig <hch@infradead.org> - 2017-05-05 13:30 +0200
          Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-05 13:40 +0200
  Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Oleg Nesterov <oleg@redhat.com> - 2017-05-06 21:50 +0200
    Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-08 01:30 +0200

csiph-web