Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636165

Re: [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one

Show all headers | View raw

On 05/04/17 11:00, Rob Herring wrote:
> sparse gives the following warning for 'pci_space':
> 
> ../drivers/of/address.c:266:26: warning: incorrect type in assignment (different base types)
> ../drivers/of/address.c:266:26:    expected unsigned int [unsigned] [usertype] pci_space
> ../drivers/of/address.c:266:26:    got restricted __be32 const [usertype] <noident>
> 
> It appears that pci_space is only ever accessed on powerpc, so the endian
> swap is often not needed.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/of/address.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 02b2903fe9d2..72914cdfce2a 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -263,7 +263,7 @@ struct of_pci_range *of_pci_range_parser_one(struct of_pci_range_parser *parser,
>  	if (!parser->range || parser->range + parser->np > parser->end)
>  		return NULL;
>  
> -	range->pci_space = parser->range[0];
> +	range->pci_space = be32_to_cpup(parser->range);
>  	range->flags = of_bus_pci_get_flags(parser->range);
>  	range->pci_addr = of_read_number(parser->range + 1, ns);
>  	range->cpu_addr = of_translate_address(parser->node,
> 

Reviewed-by: Frank Rowand <frank.rowand@sony.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] of: fix sparse warnings in of_find_next_cache_node Rob Herring <robh@kernel.org> - 2017-05-04 20:10 +0200
  [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one Rob Herring <robh@kernel.org> - 2017-05-04 20:10 +0200
    Re: [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one Frank Rowand <frowand.list@gmail.com> - 2017-05-05 07:20 +0200
  [PATCH 3/3] of: fix sparse warnings in fdt, irq, and resolver code Rob Herring <robh@kernel.org> - 2017-05-04 20:10 +0200
    Re: [PATCH 3/3] of: fix sparse warnings in fdt, irq, and resolver  code Frank Rowand <frowand.list@gmail.com> - 2017-05-05 07:20 +0200
  Re: [PATCH 1/3] of: fix sparse warnings in of_find_next_cache_node Frank Rowand <frowand.list@gmail.com> - 2017-05-05 07:20 +0200

csiph-web