Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636148

Re: [linux-sunxi] Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers

Show all headers | View raw

On Fri, May 5, 2017 at 12:52 AM,  <icenowy@aosc.io> wrote:
> 在 2017-05-04 21:05，Maxime Ripard 写道：
>>
>> On Thu, May 04, 2017 at 07:48:53PM +0800, Icenowy Zheng wrote:
>>>
>>> Allwinner have a new "Display Engine 2.0" in their new SoCs, which comes
>>> with mixers to do graphic processing and feed data to TCON, like the old
>>> backends and frontends.
>>>
>>> Add support for the mixer on Allwinner V3s SoC; it's the simplest one.
>>>
>>> Currently a lot of functions are still missing -- more investigations
>>> are needed to gain enough information for them.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>> Changes in v6:
>>> - Rebased on wens's multi-pipeline patchset.
>>> Changes in v5:
>>> - Changed some code alignment.
>>> - Request real 32-bit DMA (prepare for 64-bit SoCs).
>>> Changes in v4:
>>> - Killed some dead code according to Jernej.
>>>
>>>  drivers/gpu/drm/sun4i/Kconfig       |  10 +
>>>  drivers/gpu/drm/sun4i/Makefile      |   3 +
>>>  drivers/gpu/drm/sun4i/sun8i_layer.c | 140 +++++++++++++
>>>  drivers/gpu/drm/sun4i/sun8i_layer.h |  36 ++++
>>>  drivers/gpu/drm/sun4i/sun8i_mixer.c | 394
>>> ++++++++++++++++++++++++++++++++++++
>>>  drivers/gpu/drm/sun4i/sun8i_mixer.h | 137 +++++++++++++
>>>  6 files changed, 720 insertions(+)
>>>  create mode 100644 drivers/gpu/drm/sun4i/sun8i_layer.c
>>>  create mode 100644 drivers/gpu/drm/sun4i/sun8i_layer.h
>>>  create mode 100644 drivers/gpu/drm/sun4i/sun8i_mixer.c
>>>  create mode 100644 drivers/gpu/drm/sun4i/sun8i_mixer.h
>>>

[...]

>>> diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c
>>> b/drivers/gpu/drm/sun4i/sun8i_mixer.c
>>> new file mode 100644
>>> index 000000000000..e216b84d5bb2
>>> --- /dev/null
>>> +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
>>> @@ -0,0 +1,394 @@

[...]

>>> +       list_add_tail(&mixer->engine.list, &drv->engine_list);
>>
>>
>> You didn't call INIT_LIST_HEAD on that list.
>
>
> So didn't the sun4i_backend driver...
>
> I think the mixer->engine.list only means an item in the
> engine_list, and the drv->engine_list is initialized in the
> sun4i_drv source code.

I read [1] that if the item is subsequently added to a list,
you could omit the INIT_LIST_HEAD call.

Makes sense, though you have to be sure you aren't doing anything
else with the list element.

ChenYu

[1] https://isis.poly.edu/kulesh/stuff/src/klist/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 00/13] Initial Allwinner Display Engine 2.0 Support Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 13:50 +0200
  [PATCH v6 01/13] dt-bindings: add binding for the Allwinner DE2 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 13:50 +0200
  [PATCH v6 10/13] drm/sun4i: tcon: add support for V3s TCON Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 10/13] drm/sun4i: tcon: add support for  V3s TCON Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:40 +0200
  [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for  V3s SoC Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:40 +0200
      Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for  V3s SoC icenowy@aosc.io - 2017-05-05 11:00 +0200
        Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-05-05 14:40 +0200
          Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes  for V3s SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-09 21:30 +0200
        Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes  for V3s SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-05 14:40 +0200
  [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 15:10 +0200
      Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers icenowy@aosc.io - 2017-05-04 19:00 +0200
        Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers icenowy@aosc.io - 2017-05-04 19:20 +0200
      Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers icenowy@aosc.io - 2017-05-04 19:00 +0200
        Re: [linux-sunxi] Re: [PATCH v6 08/13] drm/sun4i: add support for  Allwinner DE2 mixers Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:50 +0200
      Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers icenowy@aosc.io - 2017-05-04 19:00 +0200
        Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-05 14:40 +0200
          Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers Icenowy Zheng <icenowy@aosc.io> - 2017-05-05 14:40 +0200
            Re: [PATCH v6 08/13] drm/sun4i: add support for Allwinner DE2 mixers Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-09 22:30 +0200
  [PATCH v6 13/13] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
  [PATCH v6 09/13] drm/sun4i: Add compatible string for V3s display engine Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
  [PATCH v6 05/13] drm/sun4i: abstract a engine type Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 05/13] drm/sun4i: abstract a engine type Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:00 +0200
      Re: [linux-sunxi] [PATCH v6 05/13] drm/sun4i: abstract a engine type Chen-Yu Tsai <wens@csie.org> - 2017-05-05 10:40 +0200
      Re: [linux-sunxi] [PATCH v6 05/13] drm/sun4i: abstract a engine type icenowy@aosc.io - 2017-05-05 10:40 +0200
  [PATCH v6 04/13] drm/sun4i: return only planes for layers created Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
  [PATCH v6 03/13] dt-bindings: add bindings for DE2 on V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 03/13] dt-bindings: add bindings for DE2  on V3s SoC Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:30 +0200
  [PATCH v6 07/13] drm/sun4i: add a Kconfig option for sun4i-backend Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 07/13] drm/sun4i: add a Kconfig option  for sun4i-backend Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:20 +0200
  [PATCH v6 02/13] clk: sunxi-ng: add support for DE2 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [PATCH v6 02/13] clk: sunxi-ng: add support for DE2 CCU Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 15:00 +0200
  [PATCH v6 06/13] drm/sun4i: add a dedicated module for sun4i-backend and sun4i-layer Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 06/13] drm/sun4i: add a dedicated module  for sun4i-backend and sun4i-layer Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:20 +0200
  [PATCH v6 12/13] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 14:00 +0200
    Re: [linux-sunxi] [PATCH v6 12/13] ARM: dts: sun8i: add pinmux for  LCD pins of V3s SoC Chen-Yu Tsai <wens@csie.org> - 2017-05-05 05:30 +0200

csiph-web