Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636151
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces |
| Date | 2017-05-05 06:20 +0200 |
| Message-ID | <tDCSJ-54g-1@gated-at.bofh.it> (permalink) |
| References | <tDtZ7-7l4-5@gated-at.bofh.it> <tDtZ8-7l4-11@gated-at.bofh.it> <tDvxT-8pV-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 2017-05-04 at 21:25 +0100, Chris Wilson wrote:
> On Thu, May 04, 2017 at 11:45:48AM -0700, Laura Abbott wrote:
> >
> > Enable the GEM dma-buf import interfaces in addition to the export
> > interfaces. This lets vgem be used as a test source for other allocators
> > (e.g. Ion).
> >
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Laura Abbott <labbott@redhat.com>
> > ---
> > v4: Use new drm_gem_prime_import_dev function
> > ---
> > static const struct vm_operations_struct vgem_gem_vm_ops = {
> > @@ -114,12 +142,8 @@ static void vgem_postclose(struct drm_device *dev, struct drm_file *file)
> > kfree(vfile);
> > }
> >
> > -/* ioctls */
> > -
> > -static struct drm_gem_object *vgem_gem_create(struct drm_device *dev,
> > - struct drm_file *file,
> > - unsigned int *handle,
> > - unsigned long size)
> > +static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
> > + unsigned long size)
>
> I'm going to guess that doesn't line up anymore. If checkpatch isn't
> complaining, then sorry for the noise.
Because of the very long identifiers, perhaps a
nicer way to write this is like:
static struct drm_vgem_gem_object *
__vgen_gem_create(struct drm_device *dev, unsigned long size);
> > +static struct drm_gem_object *vgem_gem_create(struct drm_device *dev,
> > + struct drm_file *file,
> > + unsigned int *handle,
> > + unsigned long size)
>
> Ditto.
etc...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Laura Abbott <labbott@redhat.com> - 2017-05-04 20:50 +0200
Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-04 22:30 +0200
Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Joe Perches <joe@perches.com> - 2017-05-05 06:20 +0200
Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-05 11:00 +0200
Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Daniel Vetter <daniel@ffwll.ch> - 2017-05-05 09:10 +0200
csiph-web