Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1635267

[PATCH 4/6] lockdep: Combine two seq_printf() calls into one call in l_show()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 4/6] lockdep: Combine two seq_printf() calls into one call in l_show()
Date 2017-05-03 22:50 +0200
Message-ID <tD9nH-1VW-1@gated-at.bofh.it> (permalink)
References <tD9e2-1So-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 3 May 2017 21:56:11 +0200

A bit of data was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/locking/lockdep_proc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
index a353f53b6de6..2cc0ccd2b3de 100644
--- a/kernel/locking/lockdep_proc.c
+++ b/kernel/locking/lockdep_proc.c
@@ -75,7 +75,5 @@ static int l_show(struct seq_file *m, void *v)
 #endif
 
 	get_usage_chars(class, usage);
-	seq_printf(m, " %s", usage);
-
-	seq_printf(m, ": ");
+	seq_printf(m, " %s: ", usage);
 	print_name(m, class);
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] lockdep: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-03 22:40 +0200
  [PATCH 2/6] lockdep: Use seq_putc() in seq_header() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-03 22:40 +0200
  [PATCH 4/6] lockdep: Combine two seq_printf() calls into one call in  l_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-03 22:50 +0200
  [PATCH 5/6] lockdep: Improve a size determination in lock_stat_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-03 22:50 +0200
  [PATCH 6/6] lockdep: Add spaces for better code readability SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-03 22:50 +0200
  [PATCH 3/6] lockdep: Replace four seq_printf() calls by seq_puts() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-03 22:50 +0200

csiph-web