Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635175

Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print()

Show all headers | View raw

On Tue, May 2, 2017 at 12:23 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:52:29 +0200
>
> Some data were put into a sequence by five separate function calls.
> Print the same data by a single function call instead.

> -               seq_printf(s, "No config found for dev/state/pin, expected:\n");
> -               seq_printf(s, "Searched dev:%s\n", dbg->dev_name);
> -               seq_printf(s, "Searched state:%s\n", dbg->state_name);
> -               seq_printf(s, "Searched pin:%s\n", dbg->pin_name);
> -               seq_printf(s, "Use: modify config_pin <devname> "\
> -                               "<state> <pinname> <value>\n");
> +               seq_printf(s,
> +                          "No config found for dev/state/pin, expected:\n"
> +                          "Searched dev:%s\n"
> +                          "Searched state:%s\n"
> +                          "Searched pin:%s\n"
> +                          "Use: modify config_pin <devname> <state> <pinname> <value>\n",
> +                          dbg->dev_name,
> +                          dbg->state_name,
> +                          dbg->pin_name);

Please, no.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in  pinconf_dbg_config_print() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 11:30 +0200
  Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one  call in pinconf_dbg_config_print() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 19:50 +0200

csiph-web