Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.
Date	2017-05-03 18:10 +0200
Message-ID	<tD50K-7GP-43@gated-at.bofh.it> (permalink)
References	<tvvY5-8tR-5@gated-at.bofh.it> <tvvY5-8tR-3@gated-at.bofh.it> <tCZHI-3W3-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Lucas Stach <l.stach@pengutronix.de> writes:

> Hi Eric,
>
> Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt:
>> If we follow the typical pattern of the base class being the first
>> member, we can use the default dma_fence_free function.
>
> Sorry, I don't like this change.
> While it provides a bit of code simplification, it also bakes the
> implicit assumption into the code that dma_fence is the first struct
> member without any checks to validate this assumption. I would at least
> expect a build bug assert, but then the current bit of code to keep this
> explicit and self-documenting is probably just as good.

Fine with me.  Please make sure you grab patch 2, though.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. Lucas Stach <l.stach@pengutronix.de> - 2017-05-03 12:30 +0200
  Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. Eric Anholt <eric@anholt.net> - 2017-05-03 18:10 +0200

csiph-web