Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635069
| From | Adam Thomson <Adam.Thomson.Opensource@diasemi.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] ASoC: da7213: Fix incorrect usage of bitwise '&' operator for SRM check |
| Date | 2017-05-03 17:20 +0200 |
| Message-ID | <tD4em-76U-19@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
In the SRM lock check section of code the '&' bitwise operator is used as part of checking lock status. Functionally the code works as intended, but the conditional statement is a boolean comparison so should really use '&&' logical operator instead. This commit rectifies this discrepancy. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> --- sound/soc/codecs/da7213.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 12da558..d114f33 100644 --- a/sound/soc/codecs/da7213.c +++ b/sound/soc/codecs/da7213.c @@ -771,7 +771,7 @@ static int da7213_dai_event(struct snd_soc_dapm_widget *w, ++i; msleep(50); } - } while ((i < DA7213_SRM_CHECK_RETRIES) & (!srm_lock)); + } while ((i < DA7213_SRM_CHECK_RETRIES) && (!srm_lock)); if (!srm_lock) dev_warn(codec->dev, "SRM failed to lock\n"); -- 1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] ASoC: da7213: Fix incorrect usage of bitwise '&' operator for SRM check Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2017-05-03 17:20 +0200
csiph-web