Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635017

Re: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

Show all headers | View raw

On May 3 2017 22:54, Adam Thomson wrote:
> In the SRM lock check section of code the '&' bitwise operator is
> used as part of checking lock status. Functionally the code works
> as intended, but the conditional statement is a boolean comparison
> so should really use '&&' logical operator instead. This commit
> rectifies this discrepancy.
> 
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
>  sound/soc/codecs/da7218.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

> diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> index d256ebf..6e1940e 100644
> --- a/sound/soc/codecs/da7218.c
> +++ b/sound/soc/codecs/da7218.c
> @@ -1457,7 +1457,7 @@ static int da7218_dai_event(struct snd_soc_dapm_widget *w,
>  				++i;
>  				msleep(DA7218_SRM_CHECK_DELAY);
>  			}
> -		} while ((i < DA7218_SRM_CHECK_TRIES) & (!success));
> +		} while ((i < DA7218_SRM_CHECK_TRIES) && (!success));
>  
>  		if (!success)
>  			dev_warn(codec->dev, "SRM failed to lock\n");

Would you please fix codes for da7213, too?


Regards

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for  SRM check Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2017-05-03 16:00 +0200
  Re: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator  for SRM check Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-05-03 16:20 +0200
    RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&'  operator for SRM check Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2017-05-03 16:30 +0200

csiph-web