Re: [PATCH v6 2/2] tcmu: Add global data block pool support

From	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 2/2] tcmu: Add global data block pool support
Date	2017-05-02 07:30 +0200
Message-ID	<tCyxP-24R-3@gated-at.bofh.it> (permalink)
References	<tAoCC-6Wg-15@gated-at.bofh.it> <tAoCC-6Wg-21@gated-at.bofh.it> <tBRCx-lp-1@gated-at.bofh.it> <tBVmP-2D4-43@gated-at.bofh.it> <tCoyu-4dM-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2017-05-01 at 13:40 -0500, Mike Christie wrote:
> On 04/30/2017 06:29 AM, Xiubo Li wrote:
> > [...]

<SNIP>

> >> To avoid starvation, I think you want a second list/fifo that holds the
> >> watiers. In tcmu_get_empty_block if the list is not empty, record how
> >> many pages we needed and then add the device to the list and wait in
> >> tcmu_queue_cmd_ring.
> >>
> >> Above if we freed enough pages for the device at head then wake up the
> >> device.
> >>
> >> I think you also need a wake_up call in the completion path in case the
> >> initial call could not free enough pages. It could probably check if the
> >> completion was going to free enough pages for a waiter and then call
> >> wake.
> >>
> > Yes, I meant to introduce this later after this series to not let the
> > patches too
> > complex to review.
> > 
> > If you agree I will do this later, or in V7 series ?
> 
> 
> Yeah, I am ok with adding it after the initial patches go in.

Btw, adding your Acked-by for the initial merge of these.

If that's a problem, please make some noise.  ;)

Thread

[PATCH v6 0/2] tcmu: Dynamic growing data area support lixiubo@cmss.chinamobile.com - 2017-04-26 08:30 +0200
  [PATCH v6 2/2] tcmu: Add global data block pool support lixiubo@cmss.chinamobile.com - 2017-04-26 08:30 +0200
    Re: [PATCH v6 2/2] tcmu: Add global data block pool support Mike Christie <mchristi@redhat.com> - 2017-04-30 09:40 +0200
      Re: [PATCH v6 2/2] tcmu: Add global data block pool support Xiubo Li <lixiubo@cmss.chinamobile.com> - 2017-04-30 13:40 +0200
        Re: [PATCH v6 2/2] tcmu: Add global data block pool support Mike Christie <mchristi@redhat.com> - 2017-05-01 20:50 +0200
          Re: [PATCH v6 2/2] tcmu: Add global data block pool support "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-05-02 07:30 +0200
  Re: [PATCH v6 0/2] tcmu: Dynamic growing data area support "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-05-02 07:30 +0200
    答复: [PATCH v6 0/2] tcmu: Dynamic growing data area support "lixiubo" <lixiubo@cmss.chinamobile.com> - 2017-05-02 11:30 +0200

csiph-web