[PATCH v2 7/7] staging: rtl8723bs: Do not use assignment in if condition

From	Justin Vreeland <justin@jvreeland.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 7/7] staging: rtl8723bs: Do not use assignment in if condition
Date	2017-05-02 03:00 +0200
Message-ID	<tCuky-7Ii-5@gated-at.bofh.it> (permalink)
References	<tCuky-7Ii-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Ensure checkpatch compliance

Signed-off-by: Justin Vreeland <justin@jvreeland.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
---
v2:
  - Added commit message
  - Added Reviewed-by tag

 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index d654b3438af1..9bee2e40be32 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -610,7 +610,8 @@ s32	rtl8723bs_hal_xmitframe_enqueue(
 	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
 	s32 err;
 
-	if ((err = rtw_xmitframe_enqueue(padapter, pxmitframe)) != _SUCCESS) {
+	err = rtw_xmitframe_enqueue(padapter, pxmitframe);
+	if (err != _SUCCESS) {
 		rtw_free_xmitframe(pxmitpriv, pxmitframe);
 
 		pxmitpriv->tx_drop++;
-- 
2.12.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 7/7] staging: rtl8723bs: Do not use assignment in if condition Justin Vreeland <justin@jvreeland.com> - 2017-05-02 03:00 +0200

csiph-web