Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633905
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction |
| Date | 2017-05-01 23:40 +0200 |
| Message-ID | <tCrd1-5UI-57@gated-at.bofh.it> (permalink) |
| References | <tBEYF-15g-9@gated-at.bofh.it> <tCn9n-3uH-11@gated-at.bofh.it> <tCn9o-3uH-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 01, 2017 at 06:11:58PM +0100, Tuomo Rinne wrote:
>
> The commit 9304b5b0d4fe ("staging: rtl8192u: Fix sparse warnings in r8192U_dm.c")
> adds casting of le16 from cpu endianness.
> This patch converts the u4bAcParam parameter back to little-endian after
> it has been constructed.
>
> Signed-off-by: Tuomo Rinne <tuomo.rinne@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> index 283dda4..fd8225c 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> @@ -2321,10 +2321,10 @@ static void dm_check_edca_turbo(
> u1bAIFS <<= AC_PARAM_AIFS_OFFSET;
>
> u4bAcParam = op_limit | cw_max | cw_min | u1bAIFS;
> + cpu_to_le32s(u4bAcParam);
>
> write_nic_dword(dev, EDCAPARA_BE, u4bAcParam);
>
> -
Why is this line removed?
thanks,
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Fix kbuild warnings Tuomo Rinne <tuomo.rinne@gmail.com> - 2017-05-01 19:20 +0200
[PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction Tuomo Rinne <tuomo.rinne@gmail.com> - 2017-05-01 19:20 +0200
Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction Greg KH <gregkh@linuxfoundation.org> - 2017-05-01 23:40 +0200
Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction Tuomo <tuomo.rinne@gmail.com> - 2017-05-02 01:00 +0200
csiph-web