Re: [PATCH v1] selftests: Make test_harness.h more generally available

From	Shuah Khan <shuah@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] selftests: Make test_harness.h more generally available
Date	2017-05-01 21:30 +0200
Message-ID	<tCpbc-4FA-9@gated-at.bofh.it> (permalink)
References	<tBW9b-3ah-1@gated-at.bofh.it> <tC0Zb-65x-9@gated-at.bofh.it> <tC1Lz-6DY-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/30/2017 12:22 PM, Will Drewry wrote:
> On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün <mic@digikod.net> wrote:
>>> The seccomp/test_harness.h file contains useful helpers to build tests.
>>> Moving it to the selftest directory should benefit to other test
>>> components.
>>
>> Unless Shuah thinks this should live in a new include/ directory, this
>> looks fine to me.
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Same here!
> 
> Acked-by: Will Drewry <wad@chromium.org>
> 
>>

I think the location fine. It will be a good idea to write
documentation on how to use this harness. I would recommend
rename the file to kselftest_harness.h and a doc file
kselftest_harness.txt which will go into Documentation directory.

thanks,
- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] selftests: Make test_harness.h more generally available Mickaël Salaün <mic@digikod.net> - 2017-04-30 14:30 +0200
  Re: [PATCH v1] selftests: Make test_harness.h more generally available Kees Cook <keescook@chromium.org> - 2017-04-30 19:40 +0200
    Re: [PATCH v1] selftests: Make test_harness.h more generally available Will Drewry <wad@chromium.org> - 2017-04-30 20:30 +0200
      Re: [PATCH v1] selftests: Make test_harness.h more generally  available Mickaël Salaün <mic@digikod.net> - 2017-05-01 17:50 +0200
      Re: [PATCH v1] selftests: Make test_harness.h more generally  available Shuah Khan <shuah@kernel.org> - 2017-05-01 21:30 +0200

csiph-web