Re: [PATCH v3 1/5] clk: sunxi-ng: Add sun4i/sun7i CCU driver

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/5] clk: sunxi-ng: Add sun4i/sun7i CCU driver
Date	2017-05-01 18:10 +0200
Message-ID	<tCm3D-2R0-5@gated-at.bofh.it> (permalink)
References	<tAAX7-6zY-3@gated-at.bofh.it> <tAAX7-6zY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Priit,

Almost good, thanks!

On Wed, Apr 26, 2017 at 10:32:21PM +0300, Priit Laes wrote:
> +/* TODO: GPS CLK 0x0d0 */

You should still create a define in the header for this one.

> +/* Following only exist on sun7i-a20 */
> +#define CLK_MBUS		165
> +#define CLK_HDMI1_SLOW		166
> +#define CLK_HDMI1		167
> +#define CLK_OUT_A		168
> +#define CLK_OUT_B		169

Wouldn't it be better to simply create a new A20-only header that
would include the A10's and add the A20 specific clocks on top?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] ARM: sunxi: Convert sun4i/sun7i series SoCs to sunxi-ng CCU Priit Laes <plaes@plaes.org> - 2017-04-26 21:40 +0200
  [PATCH v3 2/5] dt-bindings: List devicetree binding for the CCU of Allwinner A20 Priit Laes <plaes@plaes.org> - 2017-04-26 21:40 +0200
  [PATCH v3 4/5] ARM: sun7i: Convert to CCU Priit Laes <plaes@plaes.org> - 2017-04-26 21:40 +0200
    Re: [PATCH v3 4/5] ARM: sun7i: Convert to CCU Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-01 18:10 +0200
  [PATCH v3 3/5] dt-bindings: List devicetree binding for the CCU of Allwinner A10 Priit Laes <plaes@plaes.org> - 2017-04-26 21:40 +0200
  [PATCH v3 5/5] ARM: sun4i: Convert to CCU Priit Laes <plaes@plaes.org> - 2017-04-26 21:40 +0200
  Re: [PATCH v3 1/5] clk: sunxi-ng: Add sun4i/sun7i CCU driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-01 18:10 +0200

csiph-web