Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633584
| Path | csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Peter Zijlstra <peterz@infradead.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] sched/fair: update scale invariance of PELT |
| Date | Mon, 01 May 2017 11:10:03 +0200 |
| Message-ID | <tCfvd-7cA-29@gated-at.bofh.it> (permalink) |
| References | <tuDEl-7d7-3@gated-at.bofh.it> <tBmp4-5t5-21@gated-at.bofh.it> |
| X-Original-To | Vincent Guittot <vincent.guittot@linaro.org> |
| Dkim-Signature | v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G8EkU087ZEi/4UU4Rd58dg09nq3wSh3Ho6rtbMoiwvc=; b=e0zWnzcytwVYOdtvaa56fh+Ku NCGFQdTSTaMGCEzKqktZSn798Rm1jGh1GCGQ4IbqdgFYem5x96Ot021m2/5AXNmoQJ9VXk0iuTu/D 8NQciMPnHqHgJofsIu9e2/c2D/g0zKG7dgU6qmC4bn9indPHZsoyka8tOzKumXuDfYW/WpsCpS1rz G+gzQSMcLyaVQbr8nghA3DWtJiETcmi3FK3WS6d9TpMBB7ipkU5NaLhbRbZxIbUCUkhiTjUHGn4Xv 6aa/DQywTQRdTD3AFG1CLD+DRiPdOgT6yfkdHC4rOsRMxsyiHu07PQiDlASLM/URb/n9reUAGiomS LPTrjzlsg==; |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | NeoMutt/20170113 (1.7.2) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | mingo@kernel.org, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com, yuyang.du@intel.com, pjt@google.com, bsegall@google.com |
| X-Original-Date | Mon, 1 May 2017 11:00:26 +0200 |
| X-Original-Message-ID | <20170501090026.kht6tsttn6dirbrw@hirez.programming.kicks-ass.net> |
| X-Original-References | <1491815909-13345-1-git-send-email-vincent.guittot@linaro.org> <20170428220924.mxzs43zyvfqww2ze@hirez.programming.kicks-ass.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1633584 |
Show key headers only | View raw
On Sat, Apr 29, 2017 at 12:09:24AM +0200, Peter Zijlstra wrote:
> On Mon, Apr 10, 2017 at 11:18:29AM +0200, Vincent Guittot wrote:
> > +++ b/include/linux/sched.h
> > @@ -313,6 +313,7 @@ struct load_weight {
> > */
> > struct sched_avg {
> > u64 last_update_time;
> > + u64 stolen_idle_time;
> > u64 load_sum;
> > u32 util_sum;
> > u32 period_contrib;
>
> > + if (sa->util_sum < (LOAD_AVG_MAX * 1000)) {
> > + /*
> > + * Add the idle time stolen by running at lower compute
> > + * capacity
> > + */
> > + delta += sa->stolen_idle_time;
> > + }
> > + sa->stolen_idle_time = 0;
>
>
> So I was wondering if stolen_idle_time really needs to be a u64. Afaict
> we'll be at LOAD_AVG_MAX after LOAD_AVG_MAX_N periods, or LOAD_AVG_MAX_N
> * LOAD_AVG_PERIOD time, which ends up being 11040.
* 1024 or course, but still easily fits in u32.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] sched/fair: update scale invariance of PELT Peter Zijlstra <peterz@infradead.org> - 2017-04-29 00:20 +0200
Re: [PATCH v2] sched/fair: update scale invariance of PELT Peter Zijlstra <peterz@infradead.org> - 2017-05-01 11:10 +0200
Re: [PATCH v2] sched/fair: update scale invariance of PELT Vincent Guittot <vincent.guittot@linaro.org> - 2017-05-02 15:40 +0200
csiph-web