Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634820

[PATCH] fs: namei: use __pure modifier as declared in headers

Show all headers | View raw

sparse complains about different modifiers here. The function definitions
should simply use their declarations' modifiers.

We also shrink the text width to our 80 characters maximum while we are
at it. This makes it sparse- and checkpatch-clean.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
 fs/namei.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index d7b88c7..3d18a8c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1925,7 +1925,8 @@ static inline unsigned int fold_hash(unsigned long x, unsigned long y)
  * payload bytes, to match the way that hash_name() iterates until it
  * finds the delimiter after the name.
  */
-unsigned int full_name_hash(const void *salt, const char *name, unsigned int len)
+unsigned int __pure full_name_hash(const void *salt, const char *name,
+				   unsigned int len)
 {
 	unsigned long a, x = 0, y = (unsigned long)salt;
 
@@ -1946,7 +1947,7 @@ unsigned int full_name_hash(const void *salt, const char *name, unsigned int len
 EXPORT_SYMBOL(full_name_hash);
 
 /* Return the "hash_len" (hash and length) of a null-terminated string */
-u64 hashlen_string(const void *salt, const char *name)
+u64 __pure hashlen_string(const void *salt, const char *name)
 {
 	unsigned long a = 0, x = 0, y = (unsigned long)salt;
 	unsigned long adata, mask, len;
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] fs: namei: use __pure modifier as declared in headers Martin Kepplinger <martink@posteo.de> - 2017-05-03 11:10 +0200

csiph-web