[PATCH 1/2] lightnvm: create cmd before allocating request

From	"Javier González" <jg@lightnvm.io>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] lightnvm: create cmd before allocating request
Date	2017-05-03 11:20 +0200
Message-ID	<tCYBX-3bN-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Create nvme command before allocating a request using
nvme_alloc_request, which uses the command direction. Up until now, the
command has been zeroized, so all commands have been allocated as a
read operation.

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/nvme/host/lightnvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index de61a4a03d78..090bbeb655bc 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -503,6 +503,8 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd)
 	if (!cmd)
 		return -ENOMEM;
 
+	nvme_nvm_rqtocmd(rq, rqd, ns, cmd);
+
 	rq = nvme_alloc_request(q, (struct nvme_command *)cmd, 0, NVME_QID_ANY);
 	if (IS_ERR(rq)) {
 		kfree(cmd);
@@ -517,8 +519,6 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd)
 		rq->__data_len = 0;
 	}
 
-	nvme_nvm_rqtocmd(rq, rqd, ns, cmd);
-
 	rq->end_io_data = rqd;
 
 	blk_execute_rq_nowait(q, NULL, rq, 0, nvme_nvm_end_io);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] lightnvm: create cmd before allocating request "Javier González" <jg@lightnvm.io> - 2017-05-03 11:20 +0200
  Re: [PATCH 1/2] lightnvm: create cmd before allocating request Matias Bjørling <m@bjorling.me> - 2017-05-04 10:10 +0200
  Re: [PATCH 1/2] lightnvm: create cmd before allocating request Christoph Hellwig <hch@infradead.org> - 2017-05-04 13:30 +0200
  Re: [PATCH 1/2] lightnvm: create cmd before allocating request Javier González <jg@lightnvm.io> - 2017-05-04 16:00 +0200
  Re: [PATCH 1/2] lightnvm: create cmd before allocating request Jens Axboe <axboe@kernel.dk> - 2017-05-04 16:20 +0200

csiph-web