Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634812

Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102

From Lars-Peter Clausen <lars@metafoo.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102
Date 2017-05-03 10:50 +0200
Message-ID <tCY8V-2Hd-7@gated-at.bofh.it> (permalink)
References (1 earlier) <tCN3Q-3du-11@gated-at.bofh.it> <tCVb4-sO-9@gated-at.bofh.it> <tCXwd-2nk-11@gated-at.bofh.it> <tCXPz-2wj-11@gated-at.bofh.it> <tCY8V-2Hd-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 05/03/2017 10:43 AM, Andy Shevchenko wrote:
>>>>>> +               .owner  = THIS_MODULE,
>>>>>
>>>>> This is redundant I'm pretty sure.
>>>>
>>>> Even in 2017, drivers keep being added that carry such assignments. Can
>>>> you explain when it is needed and when not? Otherwise, I will leave it in.
>>>
>>> The above I'm 100% sure is not needed. It's needed only in cases when
>>> framework / device core doesn't do this for ya.
>>>
>>> In the above case IIRC device core does it once for all.
> 
>> Then this is not consistently filtered out in new driver reviews. I can
>> remove it, of course.
> 
> Please, remove.
> 
> I guess many of new drivers just lack of proper review :-(
> 

The kbuild bot will even send automated patches to remove the owner field if
a patch that has the owner field is merged. So definitely remove it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-02 22:10 +0200
  Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-02 23:00 +0200
    Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-03 07:40 +0200
      Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 10:10 +0200
        Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-03 10:30 +0200
          Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 10:50 +0200
            Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Lars-Peter Clausen <lars@metafoo.de> - 2017-05-03 10:50 +0200
            Re: [PATCH v2] iio: adc: Add support for TI ADC1x8s102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-03 19:20 +0200

csiph-web