Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634718

Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels

Show all headers | View raw

Hi Sudeep,

On Tue, May 2, 2017 at 7:25 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> Hi Jassi,
>
> This series adds subchannel support to ARM MHU mailbox controller
> driver. Since SCPI never used second slot, we were able to use the
> existing driver as is. However, that's changing soon and the new
> SCMI protocol under development needs subchannel support. If you
> recall when you initially added this driver, I was pushing for some
> of these changes like threaded irq. This patch series adds support
> for the subchannels on ARM MHU controllers.
>
  There are really no "sub-channels" in the ARM MHU controller. There
are exactly three channels that work on 32bit registers. The SET/CLEAR
registers are there to prevent races between local and remote
firmware, and not to emulate virtual channels operating on single
bits. Please remember all 32-bits work together to generate one
signal.

 You arrived at the "sub-channel" idea only because your protocol uses
1-bit messages. This patchset seems rather regressive - reduce from
2^32 possible signals to mere 32, by bloating the MHU driver.

 If it's difficult to see how your protocol can be implemented over
existing controller driver, please let me know.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] mailbox: arm_mhu: add support for subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
  [PATCH 5/6] mailbox: arm_mhu: add full support for sub-channels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
  [PATCH 4/6] mailbox: arm_mhu: re-factor data structure to add subchannel support Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
  [PATCH 3/6] mailbox: arm_mhu: migrate to threaded irq handler Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
  [PATCH 6/6] mailbox: arm_mhu: add name support to record mbox-name Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
  [PATCH 2/6] Documentation: devicetree: add bindings to support ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
    Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Rob Herring <robh@kernel.org> - 2017-05-08 18:20 +0200
      Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-08 18:50 +0200
        Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-08 19:10 +0200
          Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-08 20:00 +0200
            Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-09 11:40 +0200
          Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-09 05:00 +0200
            Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-09 12:00 +0200
              Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-09 12:40 +0200
                Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-09 13:00 +0200
                Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-09 14:00 +0200
                Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-09 14:50 +0200
                Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-09 15:30 +0200
                Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-09 16:30 +0200
      Re: [PATCH 2/6] Documentation: devicetree: add bindings to support  ARM MHU subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-08 19:00 +0200
  [PATCH 1/6] mailbox: arm_mhu: reorder header inclusion and drop unneeded ones Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 16:00 +0200
  Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-03 05:20 +0200
    Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-03 11:30 +0200
      Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels Jassi Brar <jassisinghbrar@gmail.com> - 2017-05-05 13:20 +0200
        Re: [PATCH 0/6] mailbox: arm_mhu: add support for subchannels Sudeep Holla <sudeep.holla@arm.com> - 2017-05-05 13:30 +0200

csiph-web