Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634669

Re: [PATCH v4] fpga manager: Add Altera CvP driver

Show all headers | View raw

On Tue, 2017-05-02 at 11:53 +0200, Anatolij Gustschin wrote:
> On Mon, 1 May 2017 23:06:16 +0300 Andy Shevchenko andy.shevchenko@gmail.com wrote:
> > > +#define VSEC_CVP_MODE_CTRL_NUMCLKS     (0xff<<8) /* CVP_NUMCLKS */  
> > 
> > Is 0xff a mask here? (Btw, you missed spaces around <<)
> 
> yes, it is. Will add spaces (checkpatch didn't warn here).

It would with command line option --strict, otherwise not.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] fpga manager: Add Altera CvP driver Anatolij Gustschin <agust@denx.de> - 2017-04-30 21:10 +0200
  Re: [PATCH v4] fpga manager: Add Altera CvP driver Alan Tull <atull@kernel.org> - 2017-05-01 17:40 +0200
  Re: [PATCH v4] fpga manager: Add Altera CvP driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-01 22:10 +0200
    Re: [PATCH v4] fpga manager: Add Altera CvP driver Anatolij Gustschin <agust@denx.de> - 2017-05-02 12:00 +0200
      Re: [PATCH v4] fpga manager: Add Altera CvP driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-02 23:30 +0200
        Re: [PATCH v4] fpga manager: Add Altera CvP driver Anatolij Gustschin <agust@denx.de> - 2017-05-03 02:20 +0200
          Re: [PATCH v4] fpga manager: Add Altera CvP driver Alan Tull <atull@kernel.org> - 2017-05-03 16:30 +0200
          Re: [PATCH v4] fpga manager: Add Altera CvP driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 17:10 +0200
      Re: [PATCH v4] fpga manager: Add Altera CvP driver Joe Perches <joe@perches.com> - 2017-05-03 01:40 +0200
        Re: [PATCH v4] fpga manager: Add Altera CvP driver Anatolij Gustschin <agust@denx.de> - 2017-05-03 02:30 +0200

csiph-web