Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1634602

[PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in radeon_sa_bo_dump_debug_info()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in radeon_sa_bo_dump_debug_info()
Date 2017-05-02 22:10 +0200
Message-ID <tCMhs-2Xu-21@gated-at.bofh.it> (permalink)
References <tCMhr-2Xu-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 21:35:48 +0200

A few single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/radeon/radeon_sa.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_sa.c b/drivers/gpu/drm/radeon/radeon_sa.c
index 197b157b73d0..67bc3618798d 100644
--- a/drivers/gpu/drm/radeon/radeon_sa.c
+++ b/drivers/gpu/drm/radeon/radeon_sa.c
@@ -406,18 +406,15 @@ void radeon_sa_bo_dump_debug_info(struct radeon_sa_manager *sa_manager,
 	list_for_each_entry(i, &sa_manager->olist, olist) {
 		uint64_t soffset = i->soffset + sa_manager->gpu_addr;
 		uint64_t eoffset = i->eoffset + sa_manager->gpu_addr;
-		if (&i->olist == sa_manager->hole) {
-			seq_printf(m, ">");
-		} else {
-			seq_printf(m, " ");
-		}
+
+		seq_putc(m, (&i->olist == sa_manager->hole) ? '>' : ' ');
 		seq_printf(m, "[0x%010llx 0x%010llx] size %8lld",
 			   soffset, eoffset, eoffset - soffset);
 		if (i->fence) {
 			seq_printf(m, " protected by 0x%016llx on ring %d",
 				   i->fence->seq, i->fence->ring);
 		}
-		seq_printf(m, "\n");
+		seq_putc(m, '\n');
 	}
 	spin_unlock(&sa_manager->wq.lock);
 }
-- 
2.12.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 22:10 +0200
  [PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in  radeon_sa_bo_dump_debug_info() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 22:10 +0200
  [PATCH 3/3] GPU-DRM-Radeon: Use seq_puts() in  r100_debugfs_cp_csq_fifo() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-02 22:20 +0200
  Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function  implementations Michel Dänzer <michel@daenzer.net> - 2017-05-10 02:30 +0200
    Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function  implementations Michel Dänzer <michel@daenzer.net> - 2017-05-11 04:50 +0200

csiph-web