Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634571
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] usb: gadget: udc: add null check before pointer dereference |
| Date | 2017-05-02 20:50 +0200 |
| Message-ID | <tCL22-1Ui-1@gated-at.bofh.it> (permalink) |
| References | <tCJtg-17y-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2 May 2017, Gustavo A. R. Silva wrote:
> Add null check before dereferencing dev->regs pointer inside
> net2280_led_shutdown() function.
>
> Addresses-Coverity-ID: 101783
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
> Move the net2280_led_shutdown() call later.
>
> drivers/usb/gadget/udc/net2280.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> index 3828c2e..4f5c0c4 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev)
> BUG_ON(dev->driver);
>
> /* then clean up the resources we allocated during probe() */
> - net2280_led_shutdown(dev);
> if (dev->requests) {
> int i;
> for (i = 1; i < 5; i++) {
> @@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev)
> free_irq(pdev->irq, dev);
> if (dev->quirks & PLX_PCIE)
> pci_disable_msi(pdev);
> - if (dev->regs)
> + if (dev->regs) {
> + net2280_led_shutdown(dev);
> iounmap(dev->regs);
> + }
> if (dev->region)
> release_mem_region(pci_resource_start(pdev, 0),
> pci_resource_len(pdev, 0));
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] usb: gadget: udc: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-02 06:10 +0200
Re: [PATCH] usb: gadget: udc: add null check before pointer dereference Alan Stern <stern@rowland.harvard.edu> - 2017-05-02 16:40 +0200
Re: [PATCH] usb: gadget: udc: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-02 18:00 +0200
[PATCH v2] usb: gadget: udc: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-02 19:10 +0200
Re: [PATCH v2] usb: gadget: udc: add null check before pointer dereference Alan Stern <stern@rowland.harvard.edu> - 2017-05-02 20:50 +0200
csiph-web