Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634330

Re: [PATCH 13/13] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split()

Show all headers | View raw

On Tue, May 02, 2017 at 01:42:26PM +1000, NeilBrown wrote:
> blk_bio_segment_split() makes sure bios have no more than
> BIO_MAX_PAGES entries in the bi_io_vec.
> This was done because bio_clone_bioset() (when given a
> mempool bioset) could not handle larger io_vecs.
> 
> No driver uses bio_clone_bioset() any more, they all
> use bio_clone_fast() if anything, and bio_clone_fast()
> doesn't clone the bi_io_vec.

Maybe in future, some drivers still may try to use 
bio_clone_bioset() again, I suggest to add some comments
on bio_clone_bioset() to make this usage explicitly. Also
better to trigger a warning if a big src bio is passed to
bio_clone_bioset().

Thanks,
Ming

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] block: assorted cleanup for bio splitting and cloning. NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
  [PATCH 04/13] blk: use non-rescuing bioset for q->bio_split. NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
    Re: [PATCH 04/13] blk: use non-rescuing bioset for q->bio_split. Ming Lei <ming.lei@redhat.com> - 2017-05-02 14:00 +0200
    [PATCH 04/13 V2] blk: use non-rescuing bioset for q->bio_split. NeilBrown <neilb@suse.com> - 2017-05-03 01:30 +0200
  [PATCH 06/13] rbd: use bio_clone_fast() instead of bio_clone() NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
  [PATCH 10/13] xen-blkfront: remove bio splitting. NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
    Re: [PATCH 10/13] xen-blkfront: remove bio splitting. Christoph Hellwig <hch@infradead.org> - 2017-05-02 10:20 +0200
  [PATCH 07/13] drbd: use bio_clone_fast() instead of bio_clone() NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
    [PATCH 07/13 V2] drbd: use bio_clone_fast() instead of bio_clone() NeilBrown <neilb@suse.com> - 2017-05-03 01:30 +0200
  [PATCH 13/13] block: don't check for BIO_MAX_PAGES in  blk_bio_segment_split() NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
    Re: [PATCH 13/13] block: don't check for BIO_MAX_PAGES in  blk_bio_segment_split() Christoph Hellwig <hch@infradead.org> - 2017-05-02 10:20 +0200
    Re: [PATCH 13/13] block: don't check for BIO_MAX_PAGES in  blk_bio_segment_split() Ming Lei <ming.lei@redhat.com> - 2017-05-02 12:30 +0200
      Re: [PATCH 13/13] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split() NeilBrown <neilb@suse.com> - 2017-05-03 01:00 +0200
        Re: [PATCH 13/13] block: don't check for BIO_MAX_PAGES in  blk_bio_segment_split() Ming Lei <ming.lei@redhat.com> - 2017-05-03 02:00 +0200
  [PATCH 12/13] block: remove bio_clone() and all references. NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
  Re: [PATCH 00/13] block: assorted cleanup for bio splitting and cloning. NeilBrown <neilb@suse.com> - 2017-05-11 03:00 +0200

csiph-web