Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1634339

Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo

From Catalin Marinas <catalin.marinas@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo
Date 2017-05-02 13:10 +0200
Message-ID <tCDQR-5Om-1@gated-at.bofh.it> (permalink)
References <tCsiJ-6wM-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, May 02, 2017 at 12:39:13AM +0200, Heinrich Schuchardt wrote:
> There is no need to hide the model name in processes
> that are not PER_LINUX32.
> 
> So let us always provide a model name that is easily readable.
> 
> Fixes: e47b020a323d ("arm64: Provide "model name" in /proc/cpuinfo for PER_LINUX32 tasks")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  arch/arm64/kernel/cpuinfo.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index b3d5b3e8fbcb..9ad9ddcd2f19 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -118,9 +118,8 @@ static int c_show(struct seq_file *m, void *v)
>  		 * "processor".  Give glibc what it expects.
>  		 */
>  		seq_printf(m, "processor\t: %d\n", i);
> -		if (compat)
> -			seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n",
> -				   MIDR_REVISION(midr), COMPAT_ELF_PLATFORM);
> +		seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n",
> +			   MIDR_REVISION(midr), COMPAT_ELF_PLATFORM);
>  
>  		seq_printf(m, "BogoMIPS\t: %lu.%02lu\n",
>  			   loops_per_jiffy / (500000UL/HZ),

Such patch seems to come up regularly:

https://patchwork.kernel.org/patch/9303311/

(and it usually gets rejected)

-- 
Catalin

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Heinrich Schuchardt <xypron.glpk@gmx.de> - 2017-05-02 00:50 +0200
  Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Catalin Marinas <catalin.marinas@arm.com> - 2017-05-02 13:10 +0200
    Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Mark Rutland <mark.rutland@arm.com> - 2017-05-02 14:40 +0200
    Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Heinrich Schuchardt <xypron.glpk@gmx.de> - 2017-05-02 18:30 +0200
      Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Mark Rutland <mark.rutland@arm.com> - 2017-05-02 18:50 +0200
      Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Sudeep Holla <sudeep.holla@arm.com> - 2017-05-02 18:50 +0200
    Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Jon Masters <jcm@jonmasters.org> - 2017-05-06 09:00 +0200

csiph-web