Re: [PATCH v4 05/15] mtd: nand: add manufacturer specific initialization/detection steps

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 05/15] mtd: nand: add manufacturer specific initialization/detection steps
Date	2017-05-02 11:10 +0200
Message-ID	<tCBYJ-4BJ-9@gated-at.bofh.it> (permalink)
References	<sVx0J-6NW-19@gated-at.bofh.it> <sVzvz-8oo-1@gated-at.bofh.it> <tCqJY-5GO-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 1 May 2017 14:02:46 -0700
Brian Norris <computersforpeace@gmail.com> wrote:

> Hi,
> 
> On Tue, Jan 03, 2017 at 02:01:25PM +0100, Boris Brezillon wrote:
> > A lot of NANDs are implementing generic features in a non-generic way,
> > or are providing advanced auto-detection logic where the NAND ID bytes
> > meaning changes with the NAND generation.
> > 
> > Providing this vendor specific initialization step will allow us to get
> > rid of the full ids in the nand_ids table or all the vendor specific
> > cases added over the time in the generic NAND ID decoding logic.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > ---
> >  drivers/mtd/nand/nand_base.c | 67 +++++++++++++++++++++++++++++++++++---------
> >  include/linux/mtd/nand.h     | 35 +++++++++++++++++++++++
> >  2 files changed, 89 insertions(+), 13 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index efb3ade568d8..8f80faa57984 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c  
> 
> ...
> 
> > @@ -4163,6 +4196,10 @@ static int nand_detect(struct nand_chip *chip, struct nand_flash_dev *type)
> >  	if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
> >  		chip->cmdfunc = nand_command_lp;
> >  
> > +	ret = nand_manufacturer_init(chip);
> > +	if (ret)
> > +		return ret;
> > +  
> 
> AFAICT, you're leaking anything that should be cleaned up in the
> ->cleanup() hook, for any error case after this. Not absolutely critical  
> to fix immediately, but I'd expect we should fix this in the 4.12 cycle.

Yep, already acked the patch. Thanks for the fix.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 05/15] mtd: nand: add manufacturer specific  initialization/detection steps Brian Norris <computersforpeace@gmail.com> - 2017-05-01 23:10 +0200
  Re: [PATCH v4 05/15] mtd: nand: add manufacturer specific  initialization/detection steps Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-02 11:10 +0200

csiph-web