Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634222
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() |
| Date | 2017-05-02 10:10 +0200 |
| Message-ID | <tCB2G-3YK-29@gated-at.bofh.it> (permalink) |
| References | <tCwZ3-ZU-3@gated-at.bofh.it> <tCwZ4-ZU-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index d1b04b0e99cf..0975da6bebd9 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -373,8 +373,10 @@ static inline struct bio *bio_next_split(struct bio *bio, int sectors,
> return bio_split(bio, sectors, gfp, bs);
> }
>
> -extern struct bio_set *bioset_create(unsigned int, unsigned int);
> -extern struct bio_set *bioset_create_nobvec(unsigned int, unsigned int);
> +extern struct bio_set *bioset_create(unsigned int, unsigned int, int flags);
> +enum {
> + BIOSET_NEED_BVECS = BIT(0),
> +};
I really hate the BIT macro as it obsfucates what's going on.
Why not just
BIOSET_NEED_BVECS = (1 << 0),
which is a lot more intuitive.
Otherwise looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() NeilBrown <neilb@suse.com> - 2017-05-02 05:50 +0200
Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() Christoph Hellwig <hch@infradead.org> - 2017-05-02 10:10 +0200
Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() NeilBrown <neilb@suse.com> - 2017-05-02 23:50 +0200
Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() Ming Lei <ming.lei@redhat.com> - 2017-05-02 11:50 +0200
csiph-web