Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format
Date	2017-04-29 07:40 +0200
Message-ID	<tBtgR-1Xp-3@gated-at.bofh.it> (permalink)
References	<tAYG6-5Us-15@gated-at.bofh.it> <tB8m6-4bc-19@gated-at.bofh.it> <tBtgR-1Xp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 01:44:45PM -0700, Julius Werner wrote:
>     > -------------------------8<--------------------------------------------
> 
>     That needs to go below the --- line, not above it.
> 
> 
> Really? git am --scissors seems to do the right thing for me this way...

Ah, never used that option before, it's not part of my normal workflow.

> Anyway, it was only an FYI, I'll just leave it out.
>  
> 
>     When you say things like "in addition" and "finally", that implies that
>     the code needs to be broken up into multiple patches.  Rememeber, each
>     patch only should ever do 1 thing.
> 
> 
> Well... all these things are required to make the new format work. But I can
> split them up further if you like. 

Please do, makes it easier to review, right?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format Julius Werner <jwerner@chromium.org> - 2017-04-27 23:00 +0200
  Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring  buffer format Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 09:20 +0200
    Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring  buffer format Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-29 07:40 +0200

csiph-web