Re: [PATCH] staging: comedi: use memdup_user

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: comedi: use memdup_user
Date	2017-04-29 07:20 +0200
Message-ID	<tBsXv-1PB-1@gated-at.bofh.it> (permalink)
References	<tBpGh-7H8-5@gated-at.bofh.it> <tBpGh-7H8-3@gated-at.bofh.it> <tBpPX-7Lk-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 06:53:32PM -0700, Joe Perches wrote:
> On Sat, 2017-04-29 at 09:45 +0800, Geliang Tang wrote:
> > Use memdup_user() helper instead of open-coding to simplify the code.
> 
> While I doubt this is a problem, this loses
> the multiplication overflow check for
> sizeof(*insns) * insnlist.n_isns

Yes it is a problem, we need that check.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: use memdup_user Geliang Tang <geliangtang@gmail.com> - 2017-04-29 03:50 +0200
  Re: [PATCH] staging: comedi: use memdup_user Joe Perches <joe@perches.com> - 2017-04-29 04:00 +0200
    Re: [PATCH] staging: comedi: use memdup_user Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-29 07:20 +0200

csiph-web