Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison()

From	"Kani, Toshimitsu" <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison()
Date	2017-04-29 00:50 +0200
Message-ID	<tBmS5-5Fv-1@gated-at.bofh.it> (permalink)
References	<tB0ye-7ca-9@gated-at.bofh.it> <tBlW1-51T-5@gated-at.bofh.it> <tBmyK-5xk-11@gated-at.bofh.it> <tBmIp-5Bh-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-04-28 at 15:39 -0700, Dan Williams wrote:
> On Fri, Apr 28, 2017 at 3:29 PM, Kani, Toshimitsu <toshi.kani@hpe.com
> > wrote:
> > On Fri, 2017-04-28 at 14:48 -0700, Dan Williams wrote:
> > > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@hpe.com>
 :
> > > > 
> > > > -       nvdimm_forget_poison(nvdimm_bus, phys, len);
> > > > +       if (clear_err.cleared > 0)
> > > > +               nvdimm_forget_poison(nvdimm_bus, phys,
> > > > clear_err.cleared);
> > > > +
> > > >         return clear_err.cleared;
> > > 
> > > Looks, good we need to mark this for -stable since the bug is
> > > also present in current mainline.
> > > 
> > > Fixes: e046114af5fc ("libnvdimm: clear the internal poison_list
> > > when clearing badblocks")
> > 
> > Shall I send a patch based on the current mainline with cc to
> > -stable?  The func name is nvdimm_clear_from_poison_list() in the
> > mainline.
> 
> I thinks it's too late to get a fix into 4.11, especially when this
> went in broken and not a regression. I'll just tag this for -stable
> and handle the backport manually.

Sounds great. Thanks Dan!
-Toshi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Toshi Kani <toshi.kani@hpe.com> - 2017-04-28 01:00 +0200
  Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-28 23:50 +0200
    Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-04-29 00:30 +0200
      Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 00:40 +0200
        Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-04-29 00:50 +0200

csiph-web