Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633176
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0/3] dynamic_hex_dump cleanup |
| Date | 2017-04-29 00:00 +0200 |
| Message-ID | <tBm5H-55J-9@gated-at.bofh.it> (permalink) |
| References | <tBlMn-4XI-45@gated-at.bofh.it> <tBlW1-51T-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: >> More than one driver has worked around the fact that >> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > No it doesn't. builds work fine. Output is restricted. > >> Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be >> turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump() >> directly. > > I think the concept is unnecessary > . > Just use print_hex_dump with KERN_DEBUG. No, we don't want any possibility of output in the CONFIG_DYNAMIC_DEBUG=n case. This is extra debug that only makes sense in the CONFIG_DYNAMIC_DEBUG case.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] dynamic_hex_dump cleanup Dan Williams <dan.j.williams@intel.com> - 2017-04-28 23:40 +0200
[PATCH 2/3] virtio, rpmsg: switch to dynamic_hex_dump() Dan Williams <dan.j.williams@intel.com> - 2017-04-28 23:40 +0200
[PATCH 3/3] acpi, nfit: kill ACPI_NFIT_DEBUG, switch to dynamic_hex_dump() Dan Williams <dan.j.williams@intel.com> - 2017-04-28 23:40 +0200
[PATCH v2] acpi, nfit: kill ACPI_NFIT_DEBUG Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:00 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Joe Perches <joe@perches.com> - 2017-04-28 23:50 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams <dan.j.williams@intel.com> - 2017-04-29 00:00 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Joe Perches <joe@perches.com> - 2017-04-29 00:20 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams <dan.j.williams@intel.com> - 2017-04-29 00:20 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams <dan.j.williams@intel.com> - 2017-04-29 00:30 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Joe Perches <joe@perches.com> - 2017-04-29 00:40 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams <dan.j.williams@intel.com> - 2017-04-29 01:00 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Joe Perches <joe@perches.com> - 2017-04-29 01:10 +0200
Re: [PATCH 0/3] dynamic_hex_dump cleanup Dan Williams <dan.j.williams@intel.com> - 2017-04-29 01:20 +0200
csiph-web