[PATCH 1/3] printk: provide generic dynamic_hex_dump fallback

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] printk: provide generic dynamic_hex_dump fallback
Date	2017-04-28 23:40 +0200
Message-ID	<tBlMn-4XI-43@gated-at.bofh.it> (permalink)
References	<tBlMn-4XI-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The lack of a silent fallback for this routine has caused the nfit
driver and the virtio_rpmsg_bus to develop local workarounds. Define a
nop version of dynamic_hex_dump() in the CONFIG_DYNAMIC_DEBUG=n case so
we can clean up those local workarounds.

Cc: Jason Baron <jbaron@akamai.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 include/linux/dynamic_debug.h |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 546d68057e3b..c26302e1e387 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -180,6 +180,12 @@ static inline int ddebug_dyndbg_module_param_cb(char *param, char *val,
 	do { if (0) printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); } while (0)
 #define dynamic_dev_dbg(dev, fmt, ...)					\
 	do { if (0) dev_printk(KERN_DEBUG, dev, fmt, ##__VA_ARGS__); } while (0)
+
+static inline void dynamic_hex_dump(const char *prefix_str, int prefix_type,
+		int rowsize, int groupsize, const void *buf, size_t len,
+		bool ascii)
+{
+}
 #endif
 
 #endif

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/3] printk: provide generic dynamic_hex_dump fallback Dan Williams <dan.j.williams@intel.com> - 2017-04-28 23:40 +0200

csiph-web