Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Date	2017-04-28 20:40 +0200
Message-ID	<tBiYa-2Rr-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <tAdxw-8iW-27@gated-at.bofh.it> <tAIKZ-3hG-1@gated-at.bofh.it> <tATQ6-2Ak-15@gated-at.bofh.it> <tB7Jn-3F8-17@gated-at.bofh.it> <tBhpn-1F2-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote:
> 
> 
> On 28/04/17 12:30 AM, Herbert Xu wrote:
> > You are right.  Indeed the existing code looks buggy as they
> > don't take sg->offset into account when doing the kmap.  Could
> > you send me some patches that fix these problems first so that
> > they can be easily backported?
> 
> Ok, I think the only buggy one in crypto is hifn_795x. Shash and caam
> both do have the sg->offset accounted for. I'll send a patch for the
> buggy one shortly.

I think they're all buggy when sg->offset is greater than PAGE_SIZE.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Thread

[PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function Logan Gunthorpe <logang@deltatee.com> - 2017-04-25 20:40 +0200
  Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map  helper function Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-27 06:00 +0200
    Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map  helper function Logan Gunthorpe <logang@deltatee.com> - 2017-04-27 17:50 +0200
      Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map  helper function Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-28 08:40 +0200
        Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map  helper function Logan Gunthorpe <logang@deltatee.com> - 2017-04-28 19:00 +0200
          Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map  helper function Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-28 20:40 +0200
            Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map  helper function Logan Gunthorpe <logang@deltatee.com> - 2017-04-28 21:10 +0200

csiph-web