Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632973
| From | Ilia Sergachev <ilia.sergachev@unibas.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] staging: ks7010: remove line continuations in quoted strings |
| Date | 2017-04-28 17:40 +0200 |
| Message-ID | <tBg9X-Qc-9@gated-at.bofh.it> (permalink) |
| References | <tBeUy-8u3-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Checkpatch emits WARNING: Avoid line continuations in quoted strings. Remove line continuations - split strings using quotes. Signed-off-by: Ilia Sergachev <ilia.sergachev@unibas.ch> --- Changes for v4: - improve indentation for better readability drivers/staging/ks7010/ks_hostif.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 7151f16e2f9c..ad8c09dd2ed1 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -191,9 +191,21 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) wireless_send_event(netdev, SIOCGIWAP, &wrqu, NULL); } DPRINTK(4, "\n Link AP\n"); - DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); + DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n" + " essid=%s\n" + " rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n" + " channel=%d\n" + " rssi=%d\n" + " sq=%d\n" + " capability=%04X\n", + ap->bssid[0], ap->bssid[1], ap->bssid[2], + ap->bssid[3], ap->bssid[4], ap->bssid[5], + &(ap->ssid.body[0]), + ap->rate_set.body[0], ap->rate_set.body[1], + ap->rate_set.body[2], ap->rate_set.body[3], + ap->rate_set.body[4], ap->rate_set.body[5], + ap->rate_set.body[6], ap->rate_set.body[7], + ap->channel, ap->rssi, ap->sq, ap->capability); DPRINTK(4, "\n Link AP\n rsn.mode=%d\n rsn.size=%d\n", ap_info->rsn_mode, ap_info->rsn.size); DPRINTK(4, "\n ext_rate_set_size=%d\n rate_set_size=%d\n", @@ -1014,9 +1026,15 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv) wstats->qual.noise = 0; /* invalid noise value */ wstats->qual.updated = IW_QUAL_ALL_UPDATED | IW_QUAL_DBM; - DPRINTK(3, "\n rssi=%u\n signal=%u\n LinkSpeed=%ux500Kbps\n \ - TransmittedFrameCount=%u\n ReceivedFragmentCount=%u\n FailedCount=%u\n \ - FCSErrorCount=%u\n", rssi, signal, LinkSpeed, TransmittedFrameCount, ReceivedFragmentCount, FailedCount, FCSErrorCount); + DPRINTK(3, "\n rssi=%u\n" + " signal=%u\n" + " LinkSpeed=%ux500Kbps\n" + " TransmittedFrameCount=%u\n" + " ReceivedFragmentCount=%u\n" + " FailedCount=%u\n" + " FCSErrorCount=%u\n", + rssi, signal, LinkSpeed, TransmittedFrameCount, + ReceivedFragmentCount, FailedCount, FCSErrorCount); /* wake_up_interruptible_all(&priv->confirm_wait); */ complete(&priv->confirm_wait); -- 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] staging: ks7010: remove line continuations in quoted strings Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-28 16:20 +0200
Re: [PATCH] staging: ks7010: remove line continuations in quoted strings Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-28 16:30 +0200
Re: [PATCH] staging: ks7010: remove line continuations in quoted strings Joe Perches <joe@perches.com> - 2017-04-28 18:50 +0200
Re: [PATCH] staging: ks7010: remove line continuations in quoted strings "Tobin C. Harding" <me@tobin.cc> - 2017-04-30 11:10 +0200
[PATCH v2] staging: ks7010: remove line continuations in quoted strings Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-28 17:40 +0200
csiph-web