[PATCH 09/14] sched/topology: Remove FORCE_SD_OVERLAP

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	[PATCH 09/14] sched/topology: Remove FORCE_SD_OVERLAP
Date	2017-04-28 15:40 +0200
Message-ID	<tBehP-7VW-13@gated-at.bofh.it> (permalink)
References	<tBehP-7VW-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Its an obsolete debug mechanism and future code wants to rely on
properties this undermines.

Namely, it would be good to assume that SD_OVERLAP domains have
children, but if we build the entire hierarchy with SD_OVERLAP this is
obviously false.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 kernel/sched/features.h |    1 -
 kernel/sched/topology.c |    2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/sched/features.h
+++ b/kernel/sched/features.h
@@ -76,7 +76,6 @@ SCHED_FEAT(WARN_DOUBLE_CLOCK, false)
 SCHED_FEAT(RT_PUSH_IPI, true)
 #endif
 
-SCHED_FEAT(FORCE_SD_OVERLAP, false)
 SCHED_FEAT(RT_RUNTIME_SHARE, true)
 SCHED_FEAT(LB_MIN, false)
 SCHED_FEAT(ATTACH_AGE_LOAD, true)
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1439,7 +1439,7 @@ build_sched_domains(const struct cpumask
 			sd = build_sched_domain(tl, cpu_map, attr, sd, i);
 			if (tl == sched_domain_topology)
 				*per_cpu_ptr(d.sd, i) = sd;
-			if (tl->flags & SDTL_OVERLAP || sched_feat(FORCE_SD_OVERLAP))
+			if (tl->flags & SDTL_OVERLAP)
 				sd->flags |= SD_OVERLAP;
 			if (cpumask_equal(cpu_map, sched_domain_span(sd)))
 				break;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 09/14] sched/topology: Remove FORCE_SD_OVERLAP Peter Zijlstra <peterz@infradead.org> - 2017-04-28 15:40 +0200

csiph-web