Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632907
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH] iov_iter: don't revert if csum error |
| Date | 2017-04-28 16:00 +0200 |
| Message-ID | <tBeBb-84B-3@gated-at.bofh.it> (permalink) |
| References | <tBdF8-7pE-15@gated-at.bofh.it> <tBdYu-7Nk-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Sabrina Dubroca > Sent: 28 April 2017 14:17 ... > > if (__skb_checksum_complete(skb)) > > - goto csum_error; > > + goto fault; > > With this patch, skb_copy_and_csum_datagram_msg() will return -EFAULT > for an incorrect checksum, that doesn't seem right. Especially since (IIRC) -EFAULT generates SIGSEGV. David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] iov_iter: don't revert if csum error Ding Tianhong <dingtianhong@huawei.com> - 2017-04-28 15:00 +0200
Re: [PATCH] iov_iter: don't revert if csum error Sabrina Dubroca <sd@queasysnail.net> - 2017-04-28 15:20 +0200
RE: [PATCH] iov_iter: don't revert if csum error David Laight <David.Laight@ACULAB.COM> - 2017-04-28 16:00 +0200
Re: [PATCH] iov_iter: don't revert if csum error Ding Tianhong <dingtianhong@huawei.com> - 2017-04-29 04:20 +0200
csiph-web