Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command
Date	2017-04-28 14:30 +0200
Message-ID	<tBdc6-7bX-31@gated-at.bofh.it> (permalink)
References	<tyKef-8vc-53@gated-at.bofh.it> <tBbtE-64f-35@gated-at.bofh.it> <tBbtE-64f-33@gated-at.bofh.it> <tBbDk-67E-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 10:47:14AM +0000, Horia Geantă wrote:
> On 4/28/2017 1:32 PM, Greg KH wrote:
> > On Sat, Apr 22, 2017 at 09:44:49AM +0300, Horia Geantă wrote:
> >> When checking the response verb, the valid bit should be masked out,
> >> since its value flips depending on what Response Register
> >> (RR0 /RR1) it's been read from.
> >>
> >> Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2")
> >> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> >> ---
> >> v2: use QBMAN_RESULT_MASK instead of hard-coded mask
> > 
> > Why are you not using 'staging' in your subject line?
> > 
> I was not aware this is required and followed the statistics:
> 
> git log --oneline drivers/staging/fsl-mc/bus/dpio/
> 141a10aead9c staging: fsl-mc/dpio: Fix early writing of valid bit
> 993fec7e11ca bus: fsl-mc: dpio: add the DPAA2 DPIO object driver
> 780b626323d7 bus: fsl-mc: dpio: add the DPAA2 DPIO service interface
> 321eecb06bfb bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2
> 2704aedb5c21 bus: fsl-mc: dpio: add APIs for DPIO objects
> 0e6437941e44 bus: fsl-mc: dpio: add DPIO driver overview document
> 
> Do I have to resubmit?

No, I have edited the subject, it should be "staging: fsl-mc: bus: ..."
for future patches.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Greg KH <gregkh@linuxfoundation.org> - 2017-04-28 12:40 +0200
  Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Horia Geantă <horia.geanta@nxp.com> - 2017-04-28 12:50 +0200
    Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Greg KH <gregkh@linuxfoundation.org> - 2017-04-28 14:30 +0200

csiph-web