[PATCH] proc: Fix unbalanced hard link numbers

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	[PATCH] proc: Fix unbalanced hard link numbers
Date	2017-04-28 15:10 +0200
Message-ID	<tBdON-7J4-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

proc_create_mount_point() forgot to increase the parent's nlink, and
it resulted in unbalanced hard link numbers, e.g. /proc/fs shows one
less than expected.

Fixes: eb6d38d5427b ("proc: Allow creating permanently empty directories...")
Cc: stable@vger.kernel.org
Reported-by: Tristan Ye <tristan.ye@suse.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 fs/proc/generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index ee27feb34cf4..9425c0d97262 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -472,6 +472,7 @@ struct proc_dir_entry *proc_create_mount_point(const char *name)
 		ent->data = NULL;
 		ent->proc_fops = NULL;
 		ent->proc_iops = NULL;
+		parent->nlink++;
 		if (proc_register(parent, ent) < 0) {
 			kfree(ent);
 			parent->nlink--;
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] proc: Fix unbalanced hard link numbers Takashi Iwai <tiwai@suse.de> - 2017-04-28 15:10 +0200
  Re: [PATCH] proc: Fix unbalanced hard link numbers ebiederm@xmission.com (Eric W. Biederman) - 2017-04-29 04:20 +0200

csiph-web