Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement

From	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement
Date	2017-04-28 14:00 +0200
Message-ID	<tBcJ4-6Ni-9@gated-at.bofh.it> (permalink)
References	<tBcJ4-6Ni-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote:
> Combine two separate set GPIO(30 & 31) operations into one statement.

Why?

> 
> Signed-off-by: Lynn Lei <lynnl.jr@outlook.com>
> ---
>  drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 68716ef7cb06..ddb7a6dc265a 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void)
>  
>  	/* Set GPIO 30 & 31 back as GPIO pins */
>  	value = peek32(GPIO_MUX);
> -	value &= ~GPIO_MUX_30;
> -	value &= ~GPIO_MUX_31;
> +	value &= ~(GPIO_MUX_30 | GPIO_MUX_31);

Why does this matter?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one  statement "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2017-04-28 14:00 +0200

csiph-web