Re: [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str

From	Ganapatrao Kulkarni <gpkulkarni@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str
Date	2017-04-28 11:30 +0200
Message-ID	<tBanT-5sv-7@gated-at.bofh.it> (permalink)
References	<tBanT-5sv-9@gated-at.bofh.it> <tBanT-5sv-11@gated-at.bofh.it> <tBanT-5sv-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 2:38 PM, Jayachandran C
<jnair@caviumnetworks.com> wrote:
> On Fri, Apr 28, 2017 at 10:23:44AM +0530, Ganapatrao Kulkarni wrote:
>> cpuid string will not be same on all CPUs on heterogeneous
>> platforms like ARM's big.LITTLE, adding provision(using pmu->cpus)
>> to find cpuid string from associated CPUs of PMU CORE device.
>>
>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>> ---
>>  tools/perf/arch/powerpc/util/header.c |  3 ++-
>>  tools/perf/arch/x86/util/header.c     |  4 +++-
>>  tools/perf/util/header.h              |  3 ++-
>>  tools/perf/util/pmu.c                 | 10 ++++++----
>>  4 files changed, 13 insertions(+), 7 deletions(-)
>>
>> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
>> index 9aaa6f5..9a70cc1 100644
>> --- a/tools/perf/arch/powerpc/util/header.c
>> +++ b/tools/perf/arch/powerpc/util/header.c
>> @@ -34,10 +34,11 @@
>>  }
>>
>>  char *
>> -get_cpuid_str(void)
>> +get_cpuid_str(struct perf_pmu *pmu)
>>  {
>>       char *bufp;
>>
>> +     do { if (pmu) {} } while (0);
>
> If this is to avoid warnings, can you use __maybe_unused here?

thanks, i will do.
>
> JC.

thanks
Ganapat

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2017-04-28 11:30 +0200

csiph-web