Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632721
| From | Alexander Graf <agraf@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] ceph: Fix file open flags on ppc64 |
| Date | 2017-04-28 11:20 +0200 |
| Message-ID | <tBaef-5ps-41@gated-at.bofh.it> (permalink) |
| References | <tAUCt-3ai-1@gated-at.bofh.it> <tB8YO-4q5-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28.04.17 09:57, Yan, Zheng wrote:
>
>> On 28 Apr 2017, at 00:34, Alexander Graf <agraf@suse.de> wrote:
>>
>> The file open flags (O_foo) are platform specific and should never go
>> out to an interface that is not local to the system.
>>
>> Unfortunately these flags have leaked out onto the wire in the cephfs
>> implementation. That lead to bogus flags getting transmitted on ppc64.
>>
>> This patch converts the kernel view of flags to the ceph view of file
>> open flags.
>>
>> Fixes: 124e68e74 ("ceph: file operations")
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>> —
>
> I removed the "unused open flags” dout and applied the patch. Thank you for tracking down and fixing the bug.
I actually put that in on purpose, in case anyone in 2 years tries to
find out why a particular flag doesn't get populated :).
Alex
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] ceph: Fix file open flags on ppc64 Alexander Graf <agraf@suse.de> - 2017-04-27 18:40 +0200
Re: [PATCH v2] ceph: Fix file open flags on ppc64 "Yan, Zheng" <zyan@redhat.com> - 2017-04-28 10:00 +0200
Re: [PATCH v2] ceph: Fix file open flags on ppc64 Alexander Graf <agraf@suse.de> - 2017-04-28 11:20 +0200
Re: [PATCH v2] ceph: Fix file open flags on ppc64 "Yan, Zheng" <zyan@redhat.com> - 2017-04-28 11:30 +0200
csiph-web