Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1632709

Re: [PATCH] pwm: sun4i: switch to atomic PWM

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH] pwm: sun4i: switch to atomic PWM
Date 2017-04-28 11:10 +0200
Message-ID <tBa4y-5m0-35@gated-at.bofh.it> (permalink)
References <tAZLQ-6S4-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 28, 2017 at 12:00:02AM +0200, Alexandre Belloni wrote:
> Switch the driver to atomic PWM. This makes it easier to wait a proper
> amount of time when changing the duty cycle before disabling the channel
> (main use case is switching the duty cycle to 0 before disabling).
> 
> Also, the hardware read out is now greatly improved as it was formerly only
> handling PWM polarity.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

You have a bunch of checkpatch warnings, please fix them.

Once done, you have my reviewed-by.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] pwm: sun4i: switch to atomic PWM Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-28 00:10 +0200
  Re: [PATCH] pwm: sun4i: switch to atomic PWM Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-28 11:10 +0200
  Re: [PATCH] pwm: sun4i: switch to atomic PWM Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-28 15:40 +0200

csiph-web