Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633369
| From | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM |
| Date | 2017-04-30 04:20 +0200 |
| Message-ID | <tBMCS-5MB-3@gated-at.bofh.it> (permalink) |
| References | <tBFUK-1Hb-7@gated-at.bofh.it> <tBGQO-2fF-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Casey Schaufler wrote:
> On 4/29/2017 12:02 PM, Mickael Salaun wrote:
> > Check if the registering LSM already registered hooks just before. This
> > enable to split hook declarations into multiple files without
> > registering multiple time the same LSM name, starting from commit
> > d69dece5f5b6 ("LSM: Add /sys/kernel/security/lsm").
>
> What's special about the previous registration? Keep it
> simple and check it the name is already anywhere on the
> list and only add it if it's not already there. I don't
> see advantage to:
>
> % cat /sys/kernel/security/lsm
> capability,yama,spiffy,selinux,spiffy
>
> over
> % cat /sys/kernel/security/lsm
> capability,yama,spiffy,selinux
>
- if (lsm_append(lsm, &lsm_names) < 0)
+ if (lsm && lsm_append(lsm, &lsm_names) < 0)
in security_add_hooks()?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Mickaël Salaün <mic@digikod.net> - 2017-04-29 21:10 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Casey Schaufler <casey@schaufler-ca.com> - 2017-04-29 22:10 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-04-30 04:20 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Mickaël Salaün <mic@digikod.net> - 2017-04-30 11:40 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM James Morris <jmorris@namei.org> - 2017-05-01 01:30 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Mickaël Salaün <mic@digikod.net> - 2017-05-08 21:30 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Casey Schaufler <casey@schaufler-ca.com> - 2017-05-08 22:10 +0200
Re: [PATCH v1] LSM: Enable multiple calls to security_add_hooks() for the same LSM Mickaël Salaün <mic@digikod.net> - 2017-05-08 22:20 +0200
csiph-web