Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633347

Re: [PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver

Show all headers | View raw

Hey,

On Sat, 2017-04-29 at 11:16 -0700, Dmitry Torokhov wrote:
> "Say Y here if you wish to connect PSX (PS1/2) pad via SPI
> interface."

It should say "PlayStation 1/2 joypads". Using "Play Station" is
incorrect, PSX is a code name so you could mention it in between
brackets. Saying "pads" is also possibly confusing, Wacom tablets have
"pads", they're "joypads".

> Let's call it "PSX gamepad force feedback (rumble) support"

This should probably mention that it's force feedback support for the
PlayStation joypads when connected via SPI. Maybe it could be
automatically enabled if both the above driver is enabled and force
feedback is as well? That would save having to describe it too
verbosely.

A code comment: how does the output of this device compare to the
output of USB PlayStation adapters? It would be interesting to double-
check that what comes out of the kernel when connected either way is
the same.

Maybe Benjamin has captures for those adapters?

Cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver Tomohiro Yoshidomi <typesylph@gmail.com> - 2017-04-29 11:50 +0200
  Re: [PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad  SPI driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-04-29 20:20 +0200
    Re: [PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad  SPI driver Bastien Nocera <hadess@hadess.net> - 2017-04-29 23:20 +0200

csiph-web