Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1632586

Re: [PATCH] clk: sunxi-ng: always select CCU_GATE

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: sunxi-ng: always select CCU_GATE
Date 2017-04-28 09:40 +0200
Message-ID <tB8Fs-4jD-25@gated-at.bofh.it> (permalink)
References <tAPt7-86a-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

1;4601;0c
On Thu, Apr 27, 2017 at 01:02:31PM +0200, Arnd Bergmann wrote:
> When the base driver is enabled but all SoC specific drivers are turned
> off, we now get a build error after code was added to always refer to the
> clk gates:
> 
> drivers/clk/built-in.o: In function `ccu_pll_notifier_cb':
> :(.text+0x154f8): undefined reference to `ccu_gate_helper_disable'
> :(.text+0x15504): undefined reference to `ccu_gate_helper_enable'
> 
> This changes the Kconfig to always require the gate code to be built-in
> when CONFIG_SUNXI_CCU is set.
> 
> Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Stephen, Mike, can you apply this patch directly? This affects the
current (4.11) release, so we probably don't want to have the overhead
of a PR here :/

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] clk: sunxi-ng: always select CCU_GATE Arnd Bergmann <arnd@arndb.de> - 2017-04-27 13:10 +0200
  Re: [PATCH] clk: sunxi-ng: always select CCU_GATE Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-28 09:40 +0200
    Re: [PATCH] clk: sunxi-ng: always select CCU_GATE Stephen Boyd <sboyd@codeaurora.org> - 2017-04-28 20:00 +0200

csiph-web