Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632583
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type |
| Date | 2017-04-28 09:40 +0200 |
| Message-ID | <tB8Fr-4jD-17@gated-at.bofh.it> (permalink) |
| References | <tB0ye-7ca-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Apr 24, 2017 at 07:53:11AM +0100, Andrea della Porta wrote:
> fixed a couple of sparse warning complaining about type mismatch.
That's really vague, please be specific.
>
> Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_intent.h b/drivers/staging/lustre/lustre/include/lustre_intent.h
> index ed2b6c6..c036633 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_intent.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_intent.h
> @@ -38,7 +38,7 @@
> struct lookup_intent {
> int it_op;
> int it_create_mode;
> - __u64 it_flags;
> + fmode_t it_flags;
Are you sure? Why? What exact warning did this "fix"?
thanks,
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type Andrea della Porta <sfaragnaus@gmail.com> - 2017-04-28 01:00 +0200 Re: [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 09:40 +0200
csiph-web