Re: [PATCH] iommu: Print a message with the default domain type created

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu: Print a message with the default domain type created
Date	2017-04-26 18:00 +0200
Message-ID	<tAxwe-4hS-25@gated-at.bofh.it> (permalink)
References	<tAxwe-4hS-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Robert,

On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote:
> -	pr_info("Adding device %s to group %d\n", dev_name(dev), group->id);
> +	pr_info("Adding device %s to group %d, default domain type %d\n",
> +		dev_name(dev), group->id,
> +		group->default_domain ? group->default_domain->type : -1);

Printing just a number is not very user-friendly. We have only two
default domain-types right now, so it is sufficient to just print
additional information if a device is identity-mapped. Something like

	"Adding device %s to group %d - using identity mapping"

Regards,

	Joerg

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] iommu: Print a message with the default domain type  created Joerg Roedel <joro@8bytes.org> - 2017-04-26 18:00 +0200

csiph-web